Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppNavigation): keep border only on mobile #6008

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix(NcAppNavigation): keep border only on mobile #6008

merged 1 commit into from
Aug 22, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 22, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image

🚧 Tasks

  • Add border only on mobile and high-contrast, remove from desktop

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme
fix(NcAppNavigation): keep border only on mobile
e675505 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component design Design, UX, interface and interaction design labels Aug 22, 2024
@ShGKme ShGKme added this to the 8.17.1 milestone Aug 22, 2024
@ShGKme ShGKme self-assigned this Aug 22, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 22, 2024

/backport to next

@susnux susnux merged commit 73476cb into master Aug 22, 2024
19 checks passed
@susnux susnux deleted the fix/nc-app-navigation--border-right branch August 22, 2024 11:25
@backportbot backportbot bot mentioned this pull request Aug 22, 2024
Merged
@susnux susnux mentioned this pull request Aug 30, 2024
Merged
@Antreesy Antreesy mentioned this pull request Sep 12, 2024
Open
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Antreesy Antreesy Antreesy approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
8.17.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @susnux @Antreesy